Xandu

16 minutes ago, Julius van Vern said:

Hey Xandu, thanks for your update. It works again. I have one question though. When the mod is temporarily disabled due to issues from an update to the game and then turned back on, the players' extra slots are empty. All items and items that were in the extra slots are gone. Is the information also stored in the config or can an extra config be made for it? Is the information stored in the map? And why are all the items gone? Hope you understand my modest English

Thanks a lot

Hi. Inventories are handled by the base game. This includes loading and saving. When the base game tries to load an inventory that does not have any class mapping (no code exists to represent the inventory) it just scraps the inventory unfortunately. I already tried to work around this problem but i have not found any good solution for it. I would like it if the base game would just drop all items or would just keep the items in the inventory in the save files. But it doesn't. So as soon as player with items in this inventory joins the game the items are lost. 

6 minutes ago, Hells Razer said:

Have you not uploaded the update to the mod portal? I am looking for it but can't find the file for 1.15.

It should be the mod version 1.3. I couldn't add a game version when i uploaded it.

Hi, i uploaded a small patch that hopefully fixed some issues. I don't have so much time as would like to fix bugs and test stuff at the moment. So i am sorry that it could take some time to fix stuff. But at least this version should be compatible with version 1.15.5 and it should load skills properly. This time you should update both mods xlib and xskills.

 

Api:
    -changed some logging to get better informations for debugging

Features:
    -the rancher ability now looks for empty or part filled buckets in your inventory when milking animals(previously just used the current hot bar slot )
    -harvesting metal from locusts now yields base game metal bits
    -added new recipes to create blister steel from metal bits

Fixes:
    -hopefully fixed an issue with some configuration files
    -hopefully fixed an error that can occur with ovens
    -fixed taking a meal out of a crock not unsealing it
    -you can now take meals with quality directly out of the fire pit
    -the experience of a skill can no longer be less than 0

15 hours ago, Captain Oats said:

-BUGGED- Cooking Skill Point Add
Xandu, love your mod but I have run into a problem with you mod on a server that I play on. Played on 1.15.3 game and lastest mod version.

I noticed or rather ran into a issue when cooking with your mod. If you apply any points into the cooking skills at all while you have an item cooking in the background then it will cause a a bug where you are no longer able to cook anything more it just shows the fuel burning and no green arrow or temp going up on the food.

Thing's I've tried to fix it:

• Reloging
• Changing cooking pots
• Changing cooking spots (with diffrent pots)
• Using diffrent fuel

Now two of us on the server we play on are unable to cook anything due to this bug so I believe it's replicatable or at least has happened when we both put points into the cooking skill while cooking something.

NOTE: I went onto a single player world and tried to creative test this theory out but giving myself levels to then spend on a cooking skill didn't seem to work. As in I got the levels and put them into canteen cook but I could not put more than 6 pieces of food in each slot. So maybe there is somthing strange going on with the cooking skill?

Thanks for reading, hope this can be fixed soon.
 

Can you send me the server log files from the server where this issue occurred? Tried to reproduce it but couldn't. Even on a server.

3 hours ago, Julius van Vern said:

Hey Xandu, we have problems with the xskill Mod. We get this error. The Mod will no load our Skill-file lokadet in data/Saves/XLeveling/

All Skills at default 0

Our players have no more skills. What could be the reason that he does not use the file? I can send it to you once by PN.

Thank you

07:15:39 [Server Error] Mod exception: OnPlayerNowPlayingSystem.MissingFieldException: Field not found: 'Vintagestory.Common.PlayerInventoryManager.Inventories'.
   at XSkills.Survival.OnStrongBack(PlayerAbility playerAbility, Int32 oldTier)
   at XLib.XLeveling.Ability.OnTierChanged(PlayerAbility playerAbility, Int32 oldTier)
   at XLib.XLeveling.PlayerAbility.set_Tier(Int32 value)
   at XLib.XLeveling.PlayerSkill.FromSavedSkill(SavedPlayerSkill saved)
   at XLib.XLeveling.XLevelingServer.LoadPlayerSkillSet(IServerPlayer byPlayer)
   at XLib.XLeveling.XLevelingServer.OnPlayerJoin(IServerPlayer byPlayer)
   at Vintagestory.API.Common.PlayerDelegate.Invoke(IServerPlayer byPlayer)
   at Vintagestory.Server.ServerEventManager.TriggerPlayerNowPlaying(IServerPlayer player)
07:15:39 [Server Error] Exception: System.MissingFieldException: Field not found: 'Vintagestory.Common.PlayerInventoryManager.Inventories'.
   at XSkills.Survival.OnStrongBack(PlayerAbility playerAbility, Int32 oldTier)
   at XLib.XLeveling.Ability.OnTierChanged(PlayerAbility playerAbility, Int32 oldTier)
   at XLib.XLeveling.PlayerAbility.set_Tier(Int32 value)
   at XLib.XLeveling.PlayerSkill.FromSavedSkill(SavedPlayerSkill saved)
   at XLib.XLeveling.XLevelingServer.LoadPlayerSkillSet(IServerPlayer byPlayer)
   at XLib.XLeveling.XLevelingServer.OnPlayerJoin(IServerPlayer byPlayer)
   at Vintagestory.API.Common.PlayerDelegate.Invoke(IServerPlayer byPlayer)
   at Vintagestory.Server.ServerEventManager.TriggerPlayerNowPlaying(IServerPlayer player)

Edit: I see, the problem is currently known. Sorry for Post.

Yes. This is a MissingFieldException. It's basically the same one which crashed the game when you had a oven in 1.15.3. It's  caused by an api change in 1.15.4 in the base game.

The Exception occurs while the mod is loading the skills and therefore stops loading at this point.

On 8/8/2021 at 9:40 PM, Snowman said:

So after playing some more today, using a crock/bowl from the firepit directly results in a plain meal with no rarity. If I first remove the cooking pot from the pit and place it down, and then use a crock/bowl the meal maintains its rarity. Another quirk is that whole pies and slices weren't displaying a rarity when held, but were when placed, and did gave the appropriate buff when eaten.

Ok. I wasn't aware that you can directly take meals out of the fire pit.

2 hours ago, Vika Catova said:

Version (1.15.4 stable) broken xskills or xlib, all my levels is zero but in config file i have levels

I know. Something broke again with update 1.15.4.

1 hour ago, Chance Nettleton said:

Yes, also we can interact with it normally until we get a fire lit in it, then we crash if we touch it again.

vintagestorycrash.txt 4.75 kB · 1 download

Can you send me your server-main.txt log file?

7 minutes ago, Laimux said:

Is bug in mod?

Yeah it seems to worked fine previously. I haven't changed anything. No something is broken af. 

2 hours ago, Chance Nettleton said:

My buddy and i have a world going on 1.15.1 and we crashed when we looked at the oven. Upon reading up on here I downloaded 1.15.3 as well as the patch for the mod and everything was fine, fast forward a couple of hours and we now crash when we try to interact with the oven. Any suggestions?

Do you have a crash report?

57 minutes ago, Brent Strickland said:

Well i've gotten salt in the pot, but now i can't figure out how to get it out of the pot or bowl to use

Placing and right clicking on it should work. I probably should add a tooltip for that.

3 hours ago, Brent Strickland said:

I decided to try out teh Desalinate skill adn the cooking pot registered ti as a valid recipie, but when i added fuel the temperature of the water stayed cold and the porgress bar didn't move. is that normal or a bug?

This is usually the case when you don't have enough water in every item slot.

2 hours ago, EreticKB said:

Btw, how can i change amount of expirience for every level? I rarely play very long runs and 3-4 lvl is my cap with default amounts.

The first post in this forum thread has a configuration section. You can find there how to configure experience.

9 hours ago, Apostasia said:

The Rancher skill increases the amount of milk you get by 33% but buckets can only hold 10 liters, the default amount you get from milking. Do you have to use something else besides a bucket to get the other 3.33... liters?

Yeah you need a stack of two buckets to get the other 33%. I want to improve this so that you just need another bucket in your hotbar or inventory.

3 hours ago, Snowman said:

Just picked up Gourmet and my food has a quality when it finishes cooking but loses it if placed in any crock or bowl. This makes it so I can only get a buff from cooking meat on a campfire.

How did you put the food from the cooking pot in the bowl or crock? Internally there are something like 20 different ways to put food from pots into a container. So i may missed something there.

10 hours ago, Lisabet said:

that makes me very much happy  I'd come to accept the 21 for the most part, until it bled into the vanilla bits  and I'll admit I've missed playing with xskills  

 

*edit* doesn't the xlib version need to match the xskills version? just making sure, I only see the 0.6.0 pre6 for xlib

I usually do this for practical reasons but it is not necessary. Usually it's just fine to use the newest version of both.

Sorry that it took so long but i was quite busy with other stuff. I uploaded a patch that should fix the oven crash. Additionally it took me some time to figure out what was going on since i was not able to reproduce the crash. To make it short my testing environment automatically compiled the mod what was enough to fix the crash. So i don't have to change my code at all for this. I assume the issue was caused by an api change in the base game between the game versions 1.15.1 and 1.15.2.  I also made some changes to the metalworking skill that hopefully makes @Lisabet happy. 

Features:
    -Added 'useVanillaBits' to the metalworking skill configuration which is by default 'true'.
        -Decides whether the base game metal bits or the xskills metal bits should be used.
        -Additionally adds recipes to convert xskills metal bits into vanilla metal bits.
    -Added 'bitsForIngot' to the metalworking skill configuration which is by default 21.
        -This is the number of xskills metal bits you need to make one ingot.
    -Added 'chiselRecipesRatio' to the metalworking skill configuration which is by default '0.5f'.
        -It changes some recipes to break down forged metal items into bits for balancing reasons. It configures how many bits of the default value you will get from the recipes.
    

-fixed: you no longer need 21 vanilla metal bits to create one ingot
-fixed: cooking salt will no longer crash the game
-fixed: the game should no longer crash from ovens

5 hours ago, Brent Strickland said:

I don't know how many bugs you have related to the clay oven in 1.15. But earlier i created it in 1.15.3 and my game crashed when i placed the last voxel. I was able to finish it by turning off x-skills and x-leveling.

 

Here's the crash report if you need it:

https://pastebin.com/KP8PK14i

It's just one bug that seems to be caused by an api change in the base game between the versions 1.15.1 and 1.15.2.

10 minutes ago, l33tmaan said:

Is it possible to check if an item has been resmelted before and apply an XP penalty to that?

It isn't jus the xp. There are abilities that allow you to get more stuff from smithing or you need less meterial. If you can resmelt every thing in one ingot but you need less than an ingot to produce it trough abilities you can hust create infinite amounts of ingots.

On 7/23/2021 at 11:21 PM, Lisabet said:

xandu, would you be willing to rename your bits to something else? shards maybe? your 21:1 ratio bleeds over to the vanilla bits (chisel on ingot) and you still get 20 from that but can't recreate the ingot because it requires 21 if xlibs/xskills is on the server

 

or honestly, please go to the 20:1 ratio used by everyone else? (or make a config file where I can change it myself to 20:1)

I love xskills/xlibs but that ratio will eventually make me just stop using the mod out of frustration

This issue has nothing to do with the naming. This is easy to fix.

But at the moment i have a quite other problem.I am quite frustrated about the fact that this 'chisel smelted items into small bits' feature added a bunch of new 'resmeltable' which is quite frustrating because it turns eveything in the metalworking skill into an infintite metal loop i wanted to ptohibited at all costs. And the moment i really don't know how i should balance this without reworking or removing the whole skill tree.

4 hours ago, Julius van Vern said:

Unfortunately, I can't say. The error occurred on the server. At that time there were 6 players online. 

Well i checked the method that crashed and couldn't found any point that could cause this crash except anything else was corrupted or some other bad influence from the outside. Or i am missing something. But then i would need the exact situation to understand what happend. 

35 minutes ago, Julius van Vern said:

@XanduError Mesage again..

 

20:12:12 [Server Fatal] System.NullReferenceException: Object reference not set to an instance of an object.
   at XSkills.BlockCookingContainerPatch.Prefix(Boolean& __result, IWorldAccessor world, BlockCookingContainer __instance, ISlotProvider cookingSlotsProvider)
   at Vintagestory.GameContent.BlockCookingContainer.CanSmelt_Patch1(BlockCookingContainer this, IWorldAccessor world, ISlotProvider cookingSlotsProvider, ItemStack inputStack, ItemStack outputStack)
   at Vintagestory.GameContent.BlockEntityFirepit.canSmeltInput()
   at Vintagestory.GameContent.BlockEntityFirepit.canHeatInput()
   at Vintagestory.GameContent.BlockEntityFirepit.OnBurnTick(Single dt)
   at Vintagestory.Common.EventManager.TriggerGameTick(Int64 ellapsedMilliseconds, IWorldAccessor world)
   at Vintagestory.Server.CoreServerEventManager.TriggerGameTick(Int64 ellapsedMilliseconds, IWorldAccessor world)
   at Vintagestory.Server.ServerMain.Process()
20:12:12 [Server Fatal] System.NullReferenceException: Object reference not set to an instance of an object.
   at XSkills.BlockCookingContainerPatch.Prefix(Boolean& __result, IWorldAccessor world, BlockCookingContainer __instance, ISlotProvider cookingSlotsProvider)
   at Vintagestory.GameContent.BlockCookingContainer.CanSmelt_Patch1(BlockCookingContainer this, IWorldAccessor world, ISlotProvider cookingSlotsProvider, ItemStack inputStack, ItemStack outputStack)
   at Vintagestory.GameContent.BlockEntityFirepit.canSmeltInput()
   at Vintagestory.GameContent.BlockEntityFirepit.canHeatInput()
   at Vintagestory.GameContent.BlockEntityFirepit.OnBurnTick(Single dt)
   at Vintagestory.Common.EventManager.TriggerGameTick(Int64 ellapsedMilliseconds, IWorldAccessor world)
   at Vintagestory.Server.CoreServerEventManager.TriggerGameTick(Int64 ellapsedMilliseconds, IWorldAccessor world)
   at Vintagestory.Server.ServerMain.Process()

 

This is a different error. It seems like the changes to the games cooking system broke some things. But these errors seems to only occur sometimes. Did you have cooked something special when this happend? 

3 hours ago, Julius van Vern said:

For your information, we had this error on the console yesterday. After a restart of the server it works again. But maybe you can see what the problem was. 

Thanks for reporting this issue. But how did this happen? At the moment i have found nothing in the method that could cause this error.

1 hour ago, Lolens said:

Having minor issue without server crash. On server startup xskills prints error in console, but still working in game

server-main.txt 16.79 kB · 0 downloads

This error can still be bad. It could mean that some abilities don't work correctly. But i could not reproduce it. Do you have every of your mods up to date? Maybe it is a conflict with another mod. Have you tried starting your game with no other mod active?

32 minutes ago, Apostasia said:

I've been experimenting with the Blacksmith skill, what influences the quality of an item? I have rank 2 in the skill but I sometimes get items under the base quality of 2, what's lowering the quality of them? 

At the moment it's just skill and luck. I thought about adding other factors like i have done for food. But at the moment i hadn't come up with good ones.

Thanks to everyone how posted a crash report. Based on it i developed the version below. Can anybody, who had the mono crash, test whether this works?

xskills_v0.6.0-pre.7.zip

25 minutes ago, Solaireislove said:

I'm having the same exact issue. I've narrowed it down to only xleveling/xskills. I run my server on G-Portal, and even with the server on 1.15.1, and the mod versions of 1.15.1 I get this crash. I received the crash on the 1.15.0 version as well, with the pre 1.15.1 version of the mods. So something changed when updating to .1.15.0+ that is causing this issue. Which is a real shame because I really enjoy this mod.

Yeah but i haven't done much different stuff in the versions for 1.14 and 1.15. I just added more stuff. It would be interesting whether someone else could manage to run a server on an other platform or with an other version of mono to see if it is a problem that just occurs on G-Portal or if it is related to mono or someting.

Unfortunately the crash report doesn't tell me anything.

I uploaded a small fix that should fix a few bugs.

-updated polish translation
-hopefully fixed a crash when an other player fires up the Pit Kiln (can't test it)
-fixed a missing ',' in the german translation file
-fixed not being able to take mead out of barrels and buckets

22 hours ago, Rescon said:

If someone starts/fire up the Pit Kiln the other Players crash with the Following Log.

Running on 64 bit Windows with 16 GB RAM 
Version: v1.15.0 (Stable)16.07.2021 16:15:08: Critical error occurred
System.NullReferenceException: Der Objektverweis wurde nicht auf eine Objektinstanz festgelegt.
   bei XSkills.BlockEntityPitKilnPatch.Postfix(BlockEntityPitKiln __instance, IPlayer byPlayer)
   bei Vintagestory.GameContent.BlockEntityPitKiln.FromTreeAttributes(ITreeAttribute tree, IWorldAccessor worldForResolving)
   bei Vintagestory.Client.NoObf.ClientChunk.AddOrUpdateBlockEntityFromPacket(_ghXD5NKeifxjBZbJOwFAvz8sOqmA p, ClientMain game)
   bei Vintagestory.Client.NoObf.GeneralPacketHandler.HandleBlockEntities(_PJkWYY2en9kpG8I4bZQar7CgJDh packet)
   bei Vintagestory.Client.NoObf.ClientMain.ExecuteMainThreadTasks(Single deltaTime)
   bei _DLw29xcc4gWHWfw8Em0aOjlQATi._TFtOrZMSbYowcBNbCxzYGGi9tPB(Single )
   bei _Hx2yddcXbI4cHPSiFN8uLToeZYi._4nKLMGBXSYT0MlLMXytiZXnv1pE(Single )
   bei _Hx2yddcXbI4cHPSiFN8uLToeZYi._zuHdBQu2Ufqe6gkW2Lbew2nkMld(Single )
   bei Vintagestory.Client.NoObf.ClientPlatformWindows.window_RenderFrame(Object sender, FrameEventArgs e)
   bei System.EventHandler`1.Invoke(Object sender, TEventArgs e)
   bei OpenTK.GameWindow.RaiseRenderFrame(Double elapsed, Double& timestamp)
   bei OpenTK.GameWindow.DispatchRenderFrame()
   bei OpenTK.GameWindow.Run(Double updates_per_second, Double frames_per_second)
   bei _aZ2fvA6N0dSuJcMaBGoJm3sgDNM._I7uMuBrykFfyAmYcxlmGjnH5B6N(_gOZk4eLYIxYBLj6wraBWI9aAKFz , String[] )
   bei _Ftrf2yPR687y7LQA9DOeCuoEf4dA._I7uMuBrykFfyAmYcxlmGjnH5B6N(ThreadStart )
-------------------------------
 

Should be fixed now.

6 hours ago, Kevin C said:

Running 1.15.1 on a server and with only xskills and xlib loaded my server crashes the instant a player joins.

 

02:51:50 [Server Debug] Response from auth server: {"playername":"Sirix","entitlements":null,"valid":1}

02:51:50 [Server Notification] Delayed join, need to load one spawn chunk first.

02:51:51 [Server Notification] Placing player at 51575.3828124974 166 51245.0625000023

================================================================= Native Crash Reporting ================================================================= Got a SIGSEGV while executing native code. This usually indicates a fatal error in the mono runtime or one of the native libraries used by your application. ================================================================= ================================================================= Native stacktrace: =================================================================

0x5645899c2265 - /usr/bin/mono : (null) 0x5645899c25fc - /usr/bin/mono : (null) 0x56458996da21 - /usr/bin/mono : (null) 0x5645899bbbfb - /usr/bin/mono : (null) 0x41faf7c9 - Unknown ================================================================= Telemetry Dumper: =================================================================

Pkilling 0x7fab6ffff700 from 0x7fab91abf780

Could not exec mono-hang-watchdog, expected on path '/etc/../bin/mono-hang-watchdog' (errno 2)

Pkilling 0x7fab44be0700 from 0x7fab91abf780 Pkilling 0x7fab28ffb700 from 0x7fab91abf780

Pkilling 0x7fab4bf43700 from 0x7fab91abf780

Pkilling 0x7fab84e6d700 from 0x7fab91abf780

Pkilling 0x7fab8526f700 from 0x7fab91abf780 Pkilling 0x7fab42cff700 from 0x7fab91abf780 Pkilling 0x7fab328ff700 from 0x7fab91abf780

rate limit exceeded

================================================================= External Debugger Dump: =================================================================

Do you use mono to run the server? I have no idea how mono works neither what could cause this error. So unfortunately i think there isn't much i can do.

5 hours ago, Julius van Vern said:

Hey Xantru,

after updating to 1.15.1 and update your mod, i recive the following message from server console. 

 

08:10:53 [Server Error] Failed to load lang file xskills:lang/de.json: Newtonsoft.Json.JsonReaderException: After parsing a value an unexpected character was encountered: ". Path 'itemdesc-metalbit-zinc', line 342, position 2.
   at Newtonsoft.Json.JsonTextReader.ParsePostValue()
   at Newtonsoft.Json.JsonTextReader.Read()
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateDictionary(IDictionary dictionary, JsonReader reader, JsonDictionaryContract contract, JsonProperty containerProperty, String id)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.Deserialize(JsonReader reader, Type objectType, Boolean checkAdditionalContent)
   at Newtonsoft.Json.JsonSerializer.DeserializeInternal(JsonReader reader, Type objectType)
   at Newtonsoft.Json.JsonConvert.DeserializeObject(String value, Type type, JsonSerializerSettings settings)
   at Newtonsoft.Json.JsonConvert.DeserializeObject[T](String value, JsonSerializerSettings settings)
   at Vintagestory.API.Config.Lang.Load(ILogger logger, IAssetManager manager, String language)

Actually it seems to work. Maybe you can check this. Thank you 

 

by the way.. crate Work

Should be fixed now.