1.18.x XLib and XSkills

nebux · December 28, 2022

CTD with and without mods in 1.17.9 and xlib xskills 0.6.14.

no issues in 0.6.13 at all

Spoiler

Running on 64 bit Windows with 32 GB RAM
Game Version: v1.17.9 (Stable)
28/12/2022 15:15:50: Critical error occurred
Loaded Mods: game@1.17.9, creative@1.17.9, survival@1.17.9
System.Exception: Don't know how to instantiate collectible behavior of class 'XSkillsCarcass' did you forget to register a mapping?
   at Vintagestory.Common.ClassRegistry.CreateCollectibleBehavior(CollectibleObject collectible, String code) in VintagestoryLib\Common\ClassRegistry.cs:line 220
   at Vintagestory.Common.BlockTypeNet.ReadBlockTypePacket(Packet_BlockType packet, IWorldAccessor world, ClassRegistry registry) in VintagestoryLib\Common\Network\BlockTypeNet.cs:line 377
   at Vintagestory.Client.NoObf.GeneralPacketHandler.PopulateBlocks(Block[] blocks, Int32 start, Int32 maxCount) in VintagestoryLib\Client\Systems\GeneralPacketHandler.cs:line 536
   at Vintagestory.Client.NoObf.GeneralPacketHandler.LoadBlockTypes() in VintagestoryLib\Client\Systems\GeneralPacketHandler.cs:line 451
   at Vintagestory.Client.NoObf.GeneralPacketHandler.HandleServerAssets_Step1() in VintagestoryLib\Client\Systems\GeneralPacketHandler.cs:line 418
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem()
   at System.Threading.ThreadPoolWorkQueue.Dispatch()

Event Log entries containing Vintagestory.exe, the latest 3
==================================
{ TimeGenerated = 28/12/2022 15:15:50, Site = , Source = .NET Runtime, Message = Application: Vintagestory.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: System.Exception
   at Vintagestory.Common.ClassRegistry.CreateCollectibleBehavior(Vintagestory.API.Common.CollectibleObject, System.String)
   at Vintagestory.Common.BlockTypeNet.ReadBlockTypePacket(Packet_BlockType, Vintagestory.API.Common.IWorldAccessor, Vintagestory.Common.ClassRegistry)
   at Vintagestory.Client.NoObf.GeneralPacketHandler.PopulateBlocks(Vintagestory.API.Common.Block[], Int32, Int32)
   at Vintagestory.Client.NoObf.GeneralPacketHandler.LoadBlockTypes()
   at Vintagestory.Client.NoObf.GeneralPacketHandler.HandleServerAssets_Step1()
   at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
   at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
   at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem()
   at System.Threading.ThreadPoolWorkQueue.Dispatch()

}
--------------
{ TimeGenerated = 28/12/2022 15:15:34, Site = , Source = Windows Error Reporting, Message = Fault bucket , type 0
Event Name: APPCRASH
Response: Not available
Cab Id: 0

Problem signature:
P1: Vintagestory.exe
P2: 1.17.9.0
P3: 63501532
P4: KERNELBASE.dll
P5: 10.0.22000.1335
P6: 003161e5
P7: e0434352
P8: 000000000004441c
P9:
P10:

Attached files:

These files may be available here:
\\?\C:\ProgramData\Microsoft\Windows\WER\ReportQueue\AppCrash_Vintagestory.exe_6de83f1fe193e5ca31c2ce3d8a11133fc7c84e51_7fba9aec_a35434b2-1246-4805-849d-3e8763d1f004

Analysis symbol:
Rechecking for solution: 0
Report Id: ad1afa00-13dc-4071-8eb4-0b5238274ec0
Report Status: 131078
Hashed bucket:
Cab Guid: 0 }
--------------
{ TimeGenerated = 28/12/2022 15:15:34, Site = , Source = Windows Error Reporting, Message = Fault bucket , type 0
Event Name: CLR20r3
Response: Not available
Cab Id: 0

Problem signature:
P1: Vintagestory.exe
P2: 1.17.9.0
P3: 63501532
P4: VintagestoryLib
P5: 1.17.9.0
P6: 63501532
P7: 1578
P8: 23
P9: System.Exception
P10:

Attached files:

These files may be available here:
\\?\C:\ProgramData\Microsoft\Windows\WER\ReportQueue\AppCrash_Vintagestory.exe_1aab4bcca5864cdea9c56a2d9a330e131e54959_7fba9aec_a49555bc-9446-423f-9e10-449d89da9e0c

Analysis symbol:
Rechecking for solution: 0
Report Id: b91875e2-dc63-4380-8028-e701d31f0e68
Report Status: 131078
Hashed bucket:
Cab Guid: 0 }

Edited December 28, 2022 by nebux

Xandu · December 28, 2022

5 minutes ago, nebux said:

CTD with and without mods in 1.17.9 and xlib xskills 0.6.14.

no issues in 0.6.13 at all

Reveal hidden contents

Running on 64 bit Windows with 32 GB RAM
Game Version: v1.17.9 (Stable)
28/12/2022 15:15:50: Critical error occurred
Loaded Mods: game@1.17.9, creative@1.17.9, survival@1.17.9
System.Exception: Don't know how to instantiate collectible behavior of class 'XSkillsCarcass' did you forget to register a mapping?
   at Vintagestory.Common.ClassRegistry.CreateCollectibleBehavior(CollectibleObject collectible, String code) in VintagestoryLib\Common\ClassRegistry.cs:line 220
   at Vintagestory.Common.BlockTypeNet.ReadBlockTypePacket(Packet_BlockType packet, IWorldAccessor world, ClassRegistry registry) in VintagestoryLib\Common\Network\BlockTypeNet.cs:line 377
   at Vintagestory.Client.NoObf.GeneralPacketHandler.PopulateBlocks(Block[] blocks, Int32 start, Int32 maxCount) in VintagestoryLib\Client\Systems\GeneralPacketHandler.cs:line 536
   at Vintagestory.Client.NoObf.GeneralPacketHandler.LoadBlockTypes() in VintagestoryLib\Client\Systems\GeneralPacketHandler.cs:line 451
   at Vintagestory.Client.NoObf.GeneralPacketHandler.HandleServerAssets_Step1() in VintagestoryLib\Client\Systems\GeneralPacketHandler.cs:line 418
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem()
   at System.Threading.ThreadPoolWorkQueue.Dispatch()

Event Log entries containing Vintagestory.exe, the latest 3
==================================
{ TimeGenerated = 28/12/2022 15:15:50, Site = , Source = .NET Runtime, Message = Application: Vintagestory.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: System.Exception
   at Vintagestory.Common.ClassRegistry.CreateCollectibleBehavior(Vintagestory.API.Common.CollectibleObject, System.String)
   at Vintagestory.Common.BlockTypeNet.ReadBlockTypePacket(Packet_BlockType, Vintagestory.API.Common.IWorldAccessor, Vintagestory.Common.ClassRegistry)
   at Vintagestory.Client.NoObf.GeneralPacketHandler.PopulateBlocks(Vintagestory.API.Common.Block[], Int32, Int32)
   at Vintagestory.Client.NoObf.GeneralPacketHandler.LoadBlockTypes()
   at Vintagestory.Client.NoObf.GeneralPacketHandler.HandleServerAssets_Step1()
   at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
   at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
   at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem()
   at System.Threading.ThreadPoolWorkQueue.Dispatch()

}
--------------
{ TimeGenerated = 28/12/2022 15:15:34, Site = , Source = Windows Error Reporting, Message = Fault bucket , type 0
Event Name: APPCRASH
Response: Not available
Cab Id: 0

Problem signature:
P1: Vintagestory.exe
P2: 1.17.9.0
P3: 63501532
P4: KERNELBASE.dll
P5: 10.0.22000.1335
P6: 003161e5
P7: e0434352
P8: 000000000004441c
P9:
P10:

Attached files:

These files may be available here:
\\?\C:\ProgramData\Microsoft\Windows\WER\ReportQueue\AppCrash_Vintagestory.exe_6de83f1fe193e5ca31c2ce3d8a11133fc7c84e51_7fba9aec_a35434b2-1246-4805-849d-3e8763d1f004

Analysis symbol:
Rechecking for solution: 0
Report Id: ad1afa00-13dc-4071-8eb4-0b5238274ec0
Report Status: 131078
Hashed bucket:
Cab Guid: 0 }
--------------
{ TimeGenerated = 28/12/2022 15:15:34, Site = , Source = Windows Error Reporting, Message = Fault bucket , type 0
Event Name: CLR20r3
Response: Not available
Cab Id: 0

Problem signature:
P1: Vintagestory.exe
P2: 1.17.9.0
P3: 63501532
P4: VintagestoryLib
P5: 1.17.9.0
P6: 63501532
P7: 1578
P8: 23
P9: System.Exception
P10:

Attached files:

These files may be available here:
\\?\C:\ProgramData\Microsoft\Windows\WER\ReportQueue\AppCrash_Vintagestory.exe_1aab4bcca5864cdea9c56a2d9a330e131e54959_7fba9aec_a49555bc-9446-423f-9e10-449d89da9e0c

Analysis symbol:
Rechecking for solution: 0
Report Id: b91875e2-dc63-4380-8028-e701d31f0e68
Report Status: 131078
Hashed bucket:
Cab Guid: 0 }

I have seen this one a few times. Usually this error happens when xskills is installed on the sever but the client is missing the mod. So make sure xlib and xskills is installed and enabled on the client.

"Loaded Mods: " is also missing the mods.

Xandu · January 1, 2023

On 12/26/2022 at 12:33 PM, maxrio21 said:

Hey im from Spain and i love your mod idea, please can you send me your Git rep to check the lang and translate your files? I want to other people from my country use this mode confortable

Hi. A while ago someone else already wanted to make a spanish translation. But i don't know if he implemented it. You don't really need access to a git repository for this. You can just translate the files in the mods folder.

On 12/28/2022 at 4:09 PM, Digitalr said:

Have a suggestion for another useful skill for survival branch.

Steeplechase

Tier 1 allows increase step height to 1.2 (same as StepUp mod)

Tier 2 increase step height to 2.1 blocks. (Trained human can easy climb over 2m fence, so, imho, trained seraph can do this too)

I check this setup (with increased step height) by running intensively through mountain landscape. It is, literally, give you much more freedom of movement and increase travel speed.

This one sounds interesting and i think it would be easy to implement. I consider to add this as an ability.

Voragine · January 20, 2023

Hello, I translated the mod, I hope it helps someone. here the file (Some friends had problems to put the translation so I better eliminate the rest of the languages and just leave the one that I edit. question of changing the name of the Json file to "es-es")

xlib_v0.6.14.zip xskills_v0.6.14.zip

Edited January 21, 2023 by Voragine

Jesterspark · January 21, 2023

I have this mod on a dedicated server and while it works when I'm in a single player world it doesn't seem to on the server. I have both the .zip in the mods folder of the server but they don't seem to load when I launch it, does anyone have any idea why this might be happening?

Goose21 · January 24, 2023

Hi, thank you for this great mod! I couldn't see myself playing without it honestly. Which is why I wanted to ask if anybody else here has a problem with it occasionally just not taking effect when playing? I notice this happening most often after sleeping only to notice the "Well Rested" effect doesn't display on the HUD. I can't gain XP or benefit from any of the perks yet I can still open the menu, showing that the mod is apparently still active. This happens in single player and with LAN games but with no rhyme or reason, it just happens and I have no idea how to replicate it. Any help would be greatly appreciated. Thanks!

Xandu · January 24, 2023

On 1/21/2023 at 9:03 PM, Jesterspark said:

I have this mod on a dedicated server and while it works when I'm in a single player world it doesn't seem to on the server. I have both the .zip in the mods folder of the server but they don't seem to load when I launch it, does anyone have any idea why this might be happening?

Make sure you are using the most recent versions of xskills and xlib on your server and your client. And make sure the mod files are in the correct folder. If this doesn't help, please provide some server logs. Maybe I can find something helpful there.

16 hours ago, Goose21 said:

Hi, thank you for this great mod! I couldn't see myself playing without it honestly. Which is why I wanted to ask if anybody else here has a problem with it occasionally just not taking effect when playing? I notice this happening most often after sleeping only to notice the "Well Rested" effect doesn't display on the HUD. I can't gain XP or benefit from any of the perks yet I can still open the menu, showing that the mod is apparently still active. This happens in single player and with LAN games but with no rhyme or reason, it just happens and I have no idea how to replicate it. Any help would be greatly appreciated. Thanks!

Does this occur for all skills and abilities or just specific ones? E.g. When the bugs occurs are you getting experience from cutting trees or from digging or mining? These are quite simple skills and are a good indication if the mod works. Also remember your experience, do some stuff and relog and see if you still have the same amount of experience to see whether this is a server-client sync issue. It would also be interesting to know whether this happens after you logged into a world or after some time.

Edited January 24, 2023 by Xandu

Goose21 · January 27, 2023

On 1/24/2023 at 10:42 AM, Xandu said:

Does this occur for all skills and abilities or just specific ones? E.g. When the bugs occurs are you getting experience from cutting trees or from digging or mining? These are quite simple skills and are a good indication if the mod works. Also remember your experience, do some stuff and relog and see if you still have the same amount of experience to see whether this is a server-client sync issue. It would also be interesting to know whether this happens after you logged into a world or after some time.

Sorry for the slow reply, I've been without internet for a few days.

While the issue persists no XP is gained from any action whatsoever. Any XP gained on a run without the bug present is retained when relogging into a world just fine, however, when the bug is present any actions that would provide XP don't seem to contribute to the overall gain following a relog. This bug only seems to manifest upon the initial start of a game, regardless of whether the world is new or old. And even then it's random, it either works or it doesn't. I haven't seen it appear mid-game at any point.

Credinus · January 28, 2023

Hello! I've got a player that has been trying to play on my home server and keeps crashing with an XEffectsPatch error when he tries to connect. No other users are having this issue; the player has done a fresh reinstall of the game twice and it is still occurring. He gets past downloading all the mods upon connecting, and then it crashes to this and any further attempts to reconnect give the same error. Anyone have any ideas as to what might be causing this? As mentioned, we have three other players that are not having any issues, so I'm at a loss as to what the problem might be. The mention of the XEffectsPatch is the only thing I recognize as it's part of this mod set (which we are using on the server, server/client versions 1.17.9).

Thanks in advance for any suggestions or ideas for resolving this!

Quote

Running on 64 bit Windows with 8 GB RAM Game Version: v1.17.10 (Stable) 1/27/2023 8:19:09 PM: Critical error occurred Loaded Mods: Involved Harmony IDs: XEffectsPatch System.ObjectDisposedException: Cannot access a disposed object. Object name: 'The ThreadLocal object has been disposed.'. at System.Threading.ThreadLocal`1.GetValueSlow() at Vintagestory.API.Common.CollectibleObject.UpdateAndGetTransitionStatesNative(IWorldAccessor world, ItemSlot inslot) in VintagestoryApi\Common\Collectible\Collectible.cs:line 2213 at Vintagestory.API.Common.CollectibleObject.AppendPerishableInfoText(ItemSlot inSlot, StringBuilder dsc, IWorldAccessor world) in VintagestoryApi\Common\Collectible\Collectible.cs:line 1579 at Vintagestory.API.Common.CollectibleObject.GetHeldItemInfo_Patch1(CollectibleObject this, ItemSlot inSlot, StringBuilder dsc, IWorldAccessor world, Boolean withDebugInfo) at Vintagestory.API.Common.ItemStack.GetDescription(IWorldAccessor world, ItemSlot inSlot, Boolean debug) in VintagestoryApi\Common\Collectible\ItemStack.cs:line 372 at Vintagestory.GameContent.GuiHandbookItemStackPage..ctor(ICoreClientAPI capi, ItemStack stack) in VSSurvivalMod\Systems\Handbook\Gui\GuiHandbookItemStackPage.cs:line 42 at Vintagestory.GameContent.GuiDialogHandbook.BuildPages_Async(List`1 allstacks) in VSSurvivalMod\Systems\Handbook\Gui\GuiDialogHandbook.cs:line 516 at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx) at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx) at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem() at System.Threading.ThreadPoolWorkQueue.Dispatch() Event Log entries containing Vintagestory.exe, the latest 3 ================================== { TimeGenerated = 1/27/2023 8:19:13 PM, Site = , Source = Application Error, Message = Faulting application name: Vintagestory.exe, version: 1.17.10.0, time stamp: 0x63bbdc3a Faulting module name: KERNELBASE.dll, version: 10.0.22621.963, time stamp: 0x766ca8ae Exception code: 0xe0434352 Fault offset: 0x00000000000906bc Faulting process id: 0x0x73e0 Faulting application start time: 0x0x1d932b557c55c7f Faulting application path: C:\Users\drago\AppData\Roaming\Vintagestory\Vintagestory.exe Faulting module path: C:\WINDOWS\System32\KERNELBASE.dll Report Id: c3f487f7-48d1-438a-861b-8c37aa2db128 Faulting package full name: Faulting package-relative application ID: } -------------- { TimeGenerated = 1/27/2023 8:19:10 PM, Site = , Source = .NET Runtime, Message = Application: Vintagestory.exe Framework Version: v4.0.30319 Description: The process was terminated due to an unhandled exception. Exception Info: System.ObjectDisposedException at System.Threading.ThreadLocal`1[[System.__Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].GetValueSlow() at Vintagestory.API.Common.CollectibleObject.UpdateAndGetTransitionStatesNative(Vintagestory.API.Common.IWorldAccessor, Vintagestory.API.Common.ItemSlot) at Vintagestory.API.Common.CollectibleObject.AppendPerishableInfoText(Vintagestory.API.Common.ItemSlot, System.Text.StringBuilder, Vintagestory.API.Common.IWorldAccessor) at DynamicClass.Vintagestory.API.Common.CollectibleObject.GetHeldItemInfo_Patch1(Vintagestory.API.Common.CollectibleObject, Vintagestory.API.Common.ItemSlot, System.Text.StringBuilder, Vintagestory.API.Common.IWorldAccessor, Boolean) at Vintagestory.API.Common.ItemStack.GetDescription(Vintagestory.API.Common.IWorldAccessor, Vintagestory.API.Common.ItemSlot, Boolean) at Vintagestory.GameContent.GuiHandbookItemStackPage..ctor(Vintagestory.API.Client.ICoreClientAPI, Vintagestory.API.Common.ItemStack) at Vintagestory.GameContent.GuiDialogHandbook.BuildPages_Async(System.Collections.Generic.List`1<Vintagestory.API.Common.ItemStack>) at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean) at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean) at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem() at System.Threading.ThreadPoolWorkQueue.Dispatch() } -------------- { TimeGenerated = 1/26/2023 9:17:30 PM, Site = , Source = Windows Error Reporting, Message = Fault bucket 1746392558194827675, type 5 Event Name: CLR20r3 Response: Not available Cab Id: 0 Problem signature: P1: Vintagestory.exe P2: 1.17.9.0 P3: 63501532 P4: mscorlib P5: 4.8.9105.0 P6: 63227283 P7: 3dcb P8: 1b P9: System.ObjectDisposedException P10: Attached files: \\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER.1eff633a-5b49-4845-ab0f-ad3fccff6ff5.tmp.WERInternalMetadata.xml These files may be available here: \\?\C:\ProgramData\Microsoft\Windows\WER\ReportArchive\AppCrash_Vintagestory.exe_b1673e598bfc64344c356b44d832999463819975_7fba9aec_837b24e1-2783-483e-9403-45532c183701 Analysis symbol: Rechecking for solution: 0 Report Id: 6269f5e3-d5ab-418b-a7df-12626accac18 Report Status: 268435456 Hashed bucket: 4133548a4b01363dd83c6ec76596a19b Cab Guid: 0 }

Xandu · January 30, 2023

On 1/27/2023 at 8:21 PM, Goose21 said:

Sorry for the slow reply, I've been without internet for a few days.

While the issue persists no XP is gained from any action whatsoever. Any XP gained on a run without the bug present is retained when relogging into a world just fine, however, when the bug is present any actions that would provide XP don't seem to contribute to the overall gain following a relog. This bug only seems to manifest upon the initial start of a game, regardless of whether the world is new or old. And even then it's random, it either works or it doesn't. I haven't seen it appear mid-game at any point.

It seems like the mod does not load at all on the server side. Can you provide the client-main.txt and the server-main.txt log files after this bug occurs? Also make sure you are using the current versions of both mods xlib and xskills on the server and all clients.

On 1/28/2023 at 6:50 AM, Credinus said:

Hello! I've got a player that has been trying to play on my home server and keeps crashing with an XEffectsPatch error when he tries to connect. No other users are having this issue; the player has done a fresh reinstall of the game twice and it is still occurring. He gets past downloading all the mods upon connecting, and then it crashes to this and any further attempts to reconnect give the same error. Anyone have any ideas as to what might be causing this? As mentioned, we have three other players that are not having any issues, so I'm at a loss as to what the problem might be. The mention of the XEffectsPatch is the only thing I recognize as it's part of this mod set (which we are using on the server, server/client versions 1.17.9).

Thanks in advance for any suggestions or ideas for resolving this!

Not this one again. This crash seems to happen inside of a harmony patch. What happens is: Harmony calls some vanilla stuff than executes the XEffectsPatch method and than returns to some vanilla stuff and at this point it crashed for some reason. So it happens after the XEffectsPatch method was exectuted. The way this issue seems to be it should also occur when is xskills and xlib is disabled because it happens inside of the vanilla code and the patch method itself does nothing that should interfere with the execution of the other code. And since the issue happens outside of the code I wrote I can't even catch this crash. The report also mentioned 'The ThreadLocal object has been disposed.' which is a really weird issue since I think the local Thread should only be disposed when the whole program terminates.

But if I remember correctly someone mentioned that it could help to fix the bug when you remove the 'Playerdata' folder or something like that.

Edited January 30, 2023 by Xandu

Jesterspark · January 30, 2023

On 1/24/2023 at 8:42 AM, Xandu said:

Make sure you are using the most recent versions of xskills and xlib on your server and your client. And make sure the mod files are in the correct folder. If this doesn't help, please provide some server logs. Maybe I can find something helpful there.

I'm using the latest versions and I have them in the /mnt/Mods folder of the server, should I have these mods specifically in the mnt/data/Mods folder? Looking through the logs, it seems xskills and xlib don't instantiate.

server-debug.txt server-main.txt

Xandu · January 30, 2023

On 1/30/2023 at 3:53 PM, Jesterspark said:

I'm using the latest versions and I have them in the /mnt/Mods folder of the server, should I have these mods specifically in the mnt/data/Mods folder? Looking through the logs, it seems xskills and xlib don't instantiate.

server-debug.txt 86.56 kB · 0 downloads server-main.txt 17.83 kB · 1 download

Your server is running on the game version v1.17.6. The mod requires version v1.17.9. So you have to update the server or downgrade the mod version. You can see which version of the game is required when you download it from the modDB.

Edited January 31, 2023 by Xandu

Jesterspark · January 31, 2023

On 1/30/2023 at 8:36 AM, Xandu said:

Your server is running on the game version v1.17.6. The mod requires version v1.17.9. So you have to update the server or downgrade the mod version. You can see which version of the game is required when you download it from the modDB.

That's weird, I thought it was the most recent version because I set it up after I recently bought the game so I just assumed it was running 1.17.9 since that was the version my game was. Thanks for finding the issue

Aedis · February 2, 2023

Hello,
I tried to connect to server which is using xlib/xskills, and I repeatedly get crash of client

Game Version: v1.17.10 (Stable)
02/02/2023 23:05:44: Critical error occurred in the following mods: xskills@0.6.14, xlib@0.6.14
Loaded Mods: backpackpackplus@1.0.3, bettercrates@1.5.3, extrachests@1.6.2, juicyores@1.0.0, midnight-texturepack@1.1.0, potatoes@1.
0.8, tradeomat@1.6.3, translocatorengineeringredux@1.3.0, game@1.17.10, electricity@0.0.5, hudclock@2.8.0, jlj@1.0.3, moredoor@1.0.0
, moreicons@1.0.3, resmeltableslight@1.0.0, creative@1.17.10, survival@1.17.10, xlib@0.6.14, xskills@0.6.14
HarmonyLib.HarmonyException: Patching exception in method virtual System.Void Vintagestory.API.Common.CollectibleObject::GetHeldItem
Info(Vintagestory.API.Common.ItemSlot inSlot, System.Text.StringBuilder dsc, Vintagestory.API.Common.IWorldAccessor world, System.Bo
olean withDebugInfo) ---> System.NullReferenceException: Object reference not set to an instance of an object

if that matters, I do play on linux. In single player loading xlib/xskills (same versions) does not cause crash.

Xandu · February 3, 2023

7 hours ago, Aedis said:

Hello,
I tried to connect to server which is using xlib/xskills, and I repeatedly get crash of client

Game Version: v1.17.10 (Stable)
02/02/2023 23:05:44: Critical error occurred in the following mods: xskills@0.6.14, xlib@0.6.14
Loaded Mods: backpackpackplus@1.0.3, bettercrates@1.5.3, extrachests@1.6.2, juicyores@1.0.0, midnight-texturepack@1.1.0, potatoes@1.
0.8, tradeomat@1.6.3, translocatorengineeringredux@1.3.0, game@1.17.10, electricity@0.0.5, hudclock@2.8.0, jlj@1.0.3, moredoor@1.0.0
, moreicons@1.0.3, resmeltableslight@1.0.0, creative@1.17.10, survival@1.17.10, xlib@0.6.14, xskills@0.6.14
HarmonyLib.HarmonyException: Patching exception in method virtual System.Void Vintagestory.API.Common.CollectibleObject::GetHeldItem
Info(Vintagestory.API.Common.ItemSlot inSlot, System.Text.StringBuilder dsc, Vintagestory.API.Common.IWorldAccessor world, System.Bo
olean withDebugInfo) ---> System.NullReferenceException: Object reference not set to an instance of an object

if that matters, I do play on linux. In single player loading xlib/xskills (same versions) does not cause crash.

Hi,

Do other people on the server have the same issue? Do you have the same mod versions on your client as on the server? Have you tried it with only xlib and xskills enabled?

Aedis · February 3, 2023

6 hours ago, Xandu said:

Hi,

Do other people on the server have the same issue? Do you have the same mod versions on your client as on the server? Have you tried it with only xlib and xskills enabled?

As far as I know it works for others but they do play on windows, I do have same versions as server which are latest ones on moddb. I am not server owner so I can't alter list of mods to check if only those two alone work there, in singleplayer they don't cause problems at all. I tried peeking with dnspy what exactly is in code where it crashes in harmony patching but probably I'd need to add some debug messages there to see which assumption (in form of non null reference) in code fails.
If there is any more info I can produce myself for you let me know.

Xandu · February 3, 2023

3 hours ago, Aedis said:

As far as I know it works for others but they do play on windows, I do have same versions as server which are latest ones on moddb. I am not server owner so I can't alter list of mods to check if only those two alone work there, in singleplayer they don't cause problems at all. I tried peeking with dnspy what exactly is in code where it crashes in harmony patching but probably I'd need to add some debug messages there to see which assumption (in form of non null reference) in code fails.
If there is any more info I can produce myself for you let me know.

Ok. Can you try to join another server? Maybe it works there. Just to test it. Maybe you can get some more information from the log files. This message itself does not say much. It seems like harmony itself crashes. Which is weird because it seems to work otherwise. And harmony should not do much different when joining a server.

I have heard that some people have issues with linux but that is something I can not test by myself.

Aedis · February 3, 2023

17 minutes ago, Xandu said:

Ok. Can you try to join another server? Maybe it works there. Just to test it. Maybe you can get some more information from the log files. This message itself does not say much. It seems like harmony itself crashes. Which is weird because it seems to work otherwise. And harmony should not do much different when joining a server.

I have heard that some people have issues with linux but that is something I can not test by myself.

Sure I can try find one using xskills/xlib. I wonder to if it would be possible to do patch by patch instead patchall so I could maybe figure out which is failing? (trace was longer than I posted of course).

XSkills modSystem = api.ModLoader.GetModSystem<XSkills>(true);
XSkills.harmony = new Harmony("XSkillsPatch");
XSkills.harmony.PatchAll(Assembly.GetExecutingAssembly());
BlockEntityAnvilPatch.Apply(XSkills.harmony, api.ClassRegistry.GetBlockEntity("Anvil"));
BlockEntityOvenPatch.Apply(XSkills.harmony, api.ClassRegistry.GetBlockEntity("Oven"), modSystem);
BlockLiquidContainerTopOpenedPatch.Apply(XSkills.harmony, typeof(BlockLiquidContainerTopOpened));
CookingRecipePatch.Apply(XSkills.harmony, typeof(CookingRecipe));

Xandu · February 3, 2023

16 minutes ago, Aedis said:

Sure I can try find one using xskills/xlib. I wonder to if it would be possible to do patch by patch instead patchall so I could maybe figure out which is failing? (trace was longer than I posted of course).

XSkills modSystem = api.ModLoader.GetModSystem<XSkills>(true);
XSkills.harmony = new Harmony("XSkillsPatch");
XSkills.harmony.PatchAll(Assembly.GetExecutingAssembly());
BlockEntityAnvilPatch.Apply(XSkills.harmony, api.ClassRegistry.GetBlockEntity("Anvil"));
BlockEntityOvenPatch.Apply(XSkills.harmony, api.ClassRegistry.GetBlockEntity("Oven"), modSystem);
BlockLiquidContainerTopOpenedPatch.Apply(XSkills.harmony, typeof(BlockLiquidContainerTopOpened));
CookingRecipePatch.Apply(XSkills.harmony, typeof(CookingRecipe));

It says "Patching exception in method virtual System.Void Vintagestory.API.Common.CollectibleObject::GetHeldItemInfo(...)". So it seems like it fails at this method. Manual patching is a little bit more complicated and there are quite a lot of patches. So this isn't really suitable.

Aedis · February 3, 2023

14 minutes ago, Xandu said:

It says "Patching exception in method virtual System.Void Vintagestory.API.Common.CollectibleObject::GetHeldItemInfo(...)". So it seems like it fails at this method. Manual patching is a little bit more complicated and there are quite a lot of patches. So this isn't really suitable.

Tried different server, public one, and crash is exactly same:

Running on 64 bit Linux with 31 GB.
Game Version: v1.17.10 (Stable)
02/03/2023 19:48:27: Critical error occurred in the following mods: xskills@0.6.14, xlib@0.6.14
Loaded Mods: actuallyquicklime@1.0.6, advancedsmithing@1.3.0, animalcages@2.0.6, chiseltools@1.7.2, lanternliner@0.1.0, midnight-texturepack@1.1.0, primitivesurvival@3.1.1, game@1.17.10, conquest@0.0.15, dsdebarkedlogs@1.0.7, hudclock@2.8.0, offhanddebuffpatch@0.5.0, playercorpse@1.5.5, resmeltableslight@1.0.0, stonequarry@2.0.0-rc.4, creative@1.17.10, survival@1.17.10, xlib@0.6.14, xrowboat@0.0.5, bullseye@2.4.1, xskills@0.6.14
HarmonyLib.HarmonyException: Patching exception in method virtual System.Void Vintagestory.API.Common.CollectibleObject::GetHeldItemInfo(Vintagestory.API.Common.ItemSlot inSlot, System.Text.StringBuilder dsc, Vintagestory.API.Common.IWorldAccessor world, System.Boolean withDebugInfo) ---> System.NullReferenceException: Object reference not set to an instance of an object
  at System.Collections.Generic.LargeArrayBuilder`1[T].GetBuffer (System.Int32 index) [0x00022] in <13c0993ff82548209b09f271bd5e6a78>:0
  at System.Collections.Generic.LargeArrayBuilder`1[T].CopyTo (System.Collections.Generic.CopyPosition position, T[] array, System.Int32 arrayIndex, System.Int32 count) [0x00041] in <13c0993ff82548209b09f271bd5e6a78>:0
  at System.Collections.Generic.SparseArrayBuilder`1[T].CopyTo (T[] array, System.Int32 arrayIndex, System.Int32 count) [0x0009a] in <13c0993ff82548209b09f271bd5e6a78>:0
  at System.Collections.Generic.SparseArrayBuilder`1[T].ToArray () [0x00028] in <13c0993ff82548209b09f271bd5e6a78>:0
  at System.Linq.Enumerable+Concat2Iterator`1[TSource].ToArray () [0x00024] in <13c0993ff82548209b09f271bd5e6a78>:0
  at System.Linq.Enumerable.ToArray[TSource] (System.Collections.Generic.IEnumerable`1[T] source) [0x00021] in <13c0993ff82548209b09f271bd5e6a78>:0
  at HarmonyLib.PatchInfo.Add (System.String owner, HarmonyLib.HarmonyMethod[] add, HarmonyLib.Patch[] current) [0x00058] in <2414a8eb44e8496080270436f777e942>:0
  at HarmonyLib.PatchInfo.AddPostfixes (System.String owner, HarmonyLib.HarmonyMethod[] methods) [0x00000] in <2414a8eb44e8496080270436f777e942>:0
  at HarmonyLib.PatchClassProcessor.ProcessPatchJob (HarmonyLib.PatchJobs`1+Job[T] job) [0x0007c] in <2414a8eb44e8496080270436f777e942>:0
   --- End of inner exception stack trace ---
  at HarmonyLib.PatchClassProcessor.ReportException (System.Exception exception, System.Reflection.MethodBase original) [0x0010f] in <2414a8eb44e8496080270436f777e942>:0
  at HarmonyLib.PatchClassProcessor.Patch () [0x00095] in <2414a8eb44e8496080270436f777e942>:0
  at HarmonyLib.Harmony.<PatchAll>b__10_0 (System.Type type) [0x00007] in <2414a8eb44e8496080270436f777e942>:0
  at HarmonyLib.CollectionExtensions.Do[T] (System.Collections.Generic.IEnumerable`1[T] sequence, System.Action`1[T] action) [0x00014] in <2414a8eb44e8496080270436f777e942>:0
  at HarmonyLib.Harmony.PatchAll (System.Reflection.Assembly assembly) [0x00006] in <2414a8eb44e8496080270436f777e942>:0
  at XSkills.XSkills.DoHarmonyPatch (Vintagestory.API.Common.ICoreAPI api) [0x00030] in <d844731e3cfa45fb927bbde98a6adccb>:0
  at XSkills.XSkill.OnConfigReceived () [0x00028] in <d844731e3cfa45fb927bbde98a6adccb>:0
  at XLib.XLeveling.XLevelingClient.MessageHandler (XLib.XLeveling.SkillConfig skillConfig) [0x000ba] in <ddc7203125214092adb9042688ecd7f4>:0
  at Vintagestory.Client.NoObf.NetworkChannel+<>c__DisplayClass12_0`1[T].<SetMessageHandler>b__0 (Packet_CustomPacket p) [0x0002f] in <ff0c509c81c540cc89f5bdcbaf20f7cf>:0
  at Vintagestory.Client.NoObf.NetworkChannel.OnPacket (Packet_CustomPacket p) [0x00022] in <ff0c509c81c540cc89f5bdcbaf20f7cf>:0
  at Vintagestory.Client.NoObf.NetworkAPI.HandleCustomPacket (Packet_Server packet) [0x00031] in <ff0c509c81c540cc89f5bdcbaf20f7cf>:0
  at Vintagestory.Client.NoObf.ProcessPacketTask.ProcessPacket (Packet_Server packet) [0x00016] in <ff0c509c81c540cc89f5bdcbaf20f7cf>:0
  at Vintagestory.Client.NoObf.ProcessPacketTask.Run () [0x00000] in <ff0c509c81c540cc89f5bdcbaf20f7cf>:0
  at Vintagestory.Client.NoObf.ClientMain.ExecuteMainThreadTasks (System.Single deltaTime) [0x0008e] in <ff0c509c81c540cc89f5bdcbaf20f7cf>:0
  at Vintagestory.Client.NoObf.ClientMain.MainGameLoop (System.Single deltaTime) [0x0004e] in <ff0c509c81c540cc89f5bdcbaf20f7cf>:0
  at Vintagestory.Client.GuiScreenRunningGame.RenderToPrimary (System.Single dt) [0x0004d] in <ff0c509c81c540cc89f5bdcbaf20f7cf>:0
  at Vintagestory.Client.ScreenManager.Render (System.Single dt) [0x00079] in <ff0c509c81c540cc89f5bdcbaf20f7cf>:0
  at Vintagestory.Client.ScreenManager.OnNewFrame (System.Single dt) [0x000cc] in <ff0c509c81c540cc89f5bdcbaf20f7cf>:0
  at Vintagestory.Client.NoObf.ClientPlatformWindows.window_RenderFrame (System.Object sender, OpenTK.FrameEventArgs e) [0x00141] in <ff0c509c81c540cc89f5bdcbaf20f7cf>:0
  at (wrapper delegate-invoke) System.EventHandler`1[OpenTK.FrameEventArgs].invoke_void_object_TEventArgs(object,OpenTK.FrameEventArgs)
  at OpenTK.GameWindow.OnRenderFrame (OpenTK.FrameEventArgs e) [0x00000] in <a4886e33f9fc416195d24950e7205b94>:0
  at OpenTK.GameWindow.OnRenderFrameInternal (OpenTK.FrameEventArgs e) [0x00010] in <a4886e33f9fc416195d24950e7205b94>:0
  at OpenTK.GameWindow.RaiseRenderFrame (System.Double elapsed, System.Double& timestamp) [0x0000c] in <a4886e33f9fc416195d24950e7205b94>:0
  at OpenTK.GameWindow.DispatchRenderFrame () [0x00038] in <a4886e33f9fc416195d24950e7205b94>:0
  at OpenTK.GameWindow.Run (System.Double updates_per_second, System.Double frames_per_second) [0x00104] in <a4886e33f9fc416195d24950e7205b94>:0
  at OpenTK.GameWindow.Run () [0x00000] in <a4886e33f9fc416195d24950e7205b94>:0
  at Vintagestory.Client.ClientProgram.Start (Vintagestory.Client.ClientProgramArgs args, System.String[] rawArgs) [0x003f2] in <9940e52b0fde4ae0bd4c79fd54c9b333>:0
  at Vintagestory.Client.ClientProgram+<>c__DisplayClass14_0.<.ctor>b__0 () [0x00000] in <9940e52b0fde4ae0bd4c79fd54c9b333>:0
  at Vintagestory.ClientNative.CrashReporter.Start (System.Threading.ThreadStart start) [0x00007] in <ff0c509c81c540cc89f5bdcbaf20f7cf>:0
System.NullReferenceException: Object reference not set to an instance of an object
  at System.Collections.Generic.LargeArrayBuilder`1[T].GetBuffer (System.Int32 index) [0x00022] in <13c0993ff82548209b09f271bd5e6a78>:0
  at System.Collections.Generic.LargeArrayBuilder`1[T].CopyTo (System.Collections.Generic.CopyPosition position, T[] array, System.Int32 arrayIndex, System.Int32 count) [0x00041] in <13c0993ff82548209b09f271bd5e6a78>:0
  at System.Collections.Generic.SparseArrayBuilder`1[T].CopyTo (T[] array, System.Int32 arrayIndex, System.Int32 count) [0x0009a] in <13c0993ff82548209b09f271bd5e6a78>:0
  at System.Collections.Generic.SparseArrayBuilder`1[T].ToArray () [0x00028] in <13c0993ff82548209b09f271bd5e6a78>:0
  at System.Linq.Enumerable+Concat2Iterator`1[TSource].ToArray () [0x00024] in <13c0993ff82548209b09f271bd5e6a78>:0
  at System.Linq.Enumerable.ToArray[TSource] (System.Collections.Generic.IEnumerable`1[T] source) [0x00021] in <13c0993ff82548209b09f271bd5e6a78>:0
  at HarmonyLib.PatchInfo.Add (System.String owner, HarmonyLib.HarmonyMethod[] add, HarmonyLib.Patch[] current) [0x00058] in <2414a8eb44e8496080270436f777e942>:0
  at HarmonyLib.PatchInfo.AddPostfixes (System.String owner, HarmonyLib.HarmonyMethod[] methods) [0x00000] in <2414a8eb44e8496080270436f777e942>:0
  at HarmonyLib.PatchClassProcessor.ProcessPatchJob (HarmonyLib.PatchJobs`1+Job[T] job) [0x0007c] in <2414a8eb44e8496080270436f777e942>:0

Do you have any other hints I can try?

Credinus · February 6, 2023

Just to follow-up, Aedis' issue is the same one a player trying to connect to my server was having, and we have not been able to resolve it either. Deleting the player data did not work, and removing the XSkills/Xlib mods from the server temporarily to test caused him to lock up and not be able to connect, but also not get a crash to generate a crash report. All other players are having no issues.

That being said, I did come across another curious bug that I thought I'd bring up. With the expanded foods mod, there are some combinations of food that seem to have a rounding issue that make the number of portions XSkills sees 0; an example of cooking a single unit of egg white and a single unit of egg yolk in the cooking pot, which generates 0.5L of scrambled egg but the cooking pot and, by extension, Xskills, seems to round it down to zero. As a result, when the cooking completes, XSkills attempts to apply something from the cooking skill tree (not sure if it's XP, or something from one of the skills like shelf life or something like that) which causes a divide by zero infinite loop. This caused the server to lock up and be unusable (since even when restarting, it would immediately try and complete the division again), the fix was to temporarily remove the xskills mod and connect to let the cooking process finish out, and then add the mod back in. Definitely more of an issue with the Expanded Foods mod being able to cook less than 1 full unit, but I thought I'd post about it here in case anyone runs into the same issue and isn't sure how to fix it.

Tarquinius753 · February 25, 2023

Hey I really love the Skills but somehow i seem to have a bug. The smithing skills do not applie when smithing something. The tools do not get the quality nor does the automated smithing work. do you have any idea what could cause the problem?

Xandu · February 26, 2023

15 hours ago, Tarquinius753 said:

Hey I really love the Skills but somehow i seem to have a bug. The smithing skills do not applie when smithing something. The tools do not get the quality nor does the automated smithing work. do you have any idea what could cause the problem?

Hi.

Do you get experience when you use molds to create items like pickaxe heads? Do you have any othe mods that change how anvils work? Is this always the case or just sometimes?

Tyrell333 · March 1, 2023

Hello, I wanted to say love this mod, it adds a really nice progression feel alongside the game.

I'm having a small problem on my server, currently I'm trying to tune down the expBase and expMult. Everytime I restart the server, the mod recreates the .json files in the ModConfig. I'm using BisectHosting and the json files are located a bit farther "/home/container/data/ModConfig/data/ModConfig/XLeveling/combat.json" and wether I edit the file or not it still makes a fresh default one.

Thank you in advance if you're able to help

Tarquinius753 · March 3, 2023

I have tried to narrow it down and my suspicion as of now is that it could be a problem with the QP's Chisel Tools. But im not yet 100% sure about that.

Sign In

1.18.x XLib and XSkills

Recommended Posts

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Important Information