1.16.0 Trade-o-mat [v1.6.0]

[ZigTheHedge]

1 hour ago, Tarquinius753 said:

but we cant do trades with steel for iron bars.

What's happening exactly? What do you mean by "can't do trades"?

[Tarquinius753]

11 hours ago, ZigTheHedge said:

What's happening exactly? What do you mean by "can't do trades"?

It just tells wrong payment item even though it is the right one and there is enough stock in the trade o mat that the trade should work.

Most trades work but steel-iron doesnt work

[ZigTheHedge]

@Tarquinius753 Are you absolutely sure that you're using correct iron bars (you mean Iron Fences, right?). Because it works for me. A screenshot will help, I think...

[Tarquinius753]

9 hours ago, ZigTheHedge said:

@Tarquinius753 Are you absolutely sure that you're using correct iron bars (you mean Iron Fences, right?). Because it works for me. A screenshot will help, I think...

no i mean the iron ingots that you could smith to tools

[Tarquinius753]

The problem seems to appear also with other items lich bismuth nuggets. We have tested it with several shops and multiple players on our server.

 

[ZigTheHedge]

I need item ids or at least screenshots with mouse hovering problematic items to reproduce. Also, a complete mod list will help.

[Tarquinius753]

1 hour ago, ZigTheHedge said:

I need item ids or at least screenshots with mouse hovering problematic items to reproduce. Also, a complete mod list will help.

The person that created the shop can actually buy the items some times but other players cant. I ll try to get some screenshot next time.

[Hexedian]

Were the ingots hot when they were added to the trade-o-mat?

[Tarquinius753]

5 hours ago, Hexedian said:

Were the ingots hot when they were added to the trade-o-mat?

No they werent hot.

[Katharine D'Almaine]

Would it be possible to set up a creative style trade-o-mat? I.e. one with infinite tradeable items?

[ZigTheHedge]

3 minutes ago, Katharine D'Almaine said:

Would it be possible to set up a creative style trade-o-mat?

I also had that idea in mind, so yes, eventually )

[Rhonen]

Memory leak bug report

hey @ZigTheHedge while i search for an handling error i found out, that your Mod causes the same memory-leak.
that means, that after ending a game session, the main menu is lagging, cause garbage collector trys to do some cleanups of the memory. this was caused by holding a game-instance by ICore(Client/Server)Api references inside the mod, may be a static instance of one class in your mod or a static reference of the api.

hope you can do something with that information

Greetings.

Edited January 3, 2021 by Rhonen

[ZigTheHedge]

@RhonenThanks for the perfect indicator of memory leaks ) Found an easy fix for Tradeomat, now it's time to find it for the rest of my mods...

[ZigTheHedge]

1.4.4-B:

- Fixed ability to trade items with temperature (wow, that was hard to catch)

- Fixed memory leak (thanks, @Rhonen)

- Added three coin variants: Copper, Silver, Gold. Coins are smelted from corresponding metals using clay mold (4 coins per 100 units of metal). They also reverse-smeltable. Coins can also be placed on solid ground.

Edited January 9, 2021 by ZigTheHedge

[ZigTheHedge]

1.4.7-B:

- Added third Trade'o'mat version (named Trade'o'Rug), which allows to sell exact items (or the whole stack) for the defined price. First of all it can be used to sell such items as weapons, tools and food

- Added "Deal!" check-out sound

[MiniKarma]

Testing this on RabbitTech server, you can't see the price of the item either in the bar or hovering the object. I tried it with also linen bags.

[Aliysium]

Crashed on shift+right click on the Trade-o-stall. We are running Carry Capacity if that matters.
 

Crashlog:

Spoiler

Running on 64 bit Windows with 32 GB RAM 
Version: v1.14.6-rc.1 (Unstable)1/16/2021 10:29:32 PM: Critical error occurred
System.NullReferenceException: Object reference not set to an instance of an object.
   at Vintagestory.API.Client.GuiElementDynamicTextHelper.GetDynamicText(GuiComposer composer, String key)
   at tradeomat.src.TradeomatBlock.BETradeBlock.OnReceivedServerPacket(Int32 packetid, Byte[] data)
   at Vintagestory.Client.NoObf.GeneralPacketHandler.HandleBlockEntityMessage(_hJXkOv6VzVSb0ABUci4TpovnEXB packet)
   at Vintagestory.Client.NoObf.ClientMain.ExecuteMainThreadTasks(Single deltaTime)
   at _ynVaYlwjG1plFcllN3RN1PA1NXgA._sfOwZ2RtW7K2poPDRwFeY0WPF0d(Single )
   at _fzQ3b7qaorX7CzI4cd5tyoIYQKc._CoiccM7rGb08atDxqOUGHqFvYrE(Single )
   at _fzQ3b7qaorX7CzI4cd5tyoIYQKc._HhjImK0LGBXoUwehKzFMnL5t6zh(Single )
   at Vintagestory.Client.NoObf.ClientPlatformWindows.window_RenderFrame(Object sender, FrameEventArgs e)
   at System.EventHandler`1.Invoke(Object sender, TEventArgs e)
   at OpenTK.GameWindow.RaiseRenderFrame(Double elapsed, Double& timestamp)
   at OpenTK.GameWindow.DispatchRenderFrame()
   at OpenTK.GameWindow.Run(Double updates_per_second, Double frames_per_second)
   at _VyKFcUkfu3qblpXIOzaOKif33Izb._2kJqTFjDg5UbytVXSDIX5uwOswB(_91iJX0Fn2P0DTjnaYOodloOm7Lx , String[] )
   at _q9O3okUqEHhfTDFwXyhzv5PyDjJ._2kJqTFjDg5UbytVXSDIX5uwOswB(ThreadStart )
-------------------------------

Event Log, last 3 entries
==================================
{ TimeGenerated = 1/16/2021 10:29:32 PM, Site = , Source = .NET Runtime, Message = Application: Vintagestory.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: exception code c0020001, exception address 00007FFC18AD3B29
Stack:
 }
{ TimeGenerated = 11/19/2020 3:24:32 PM, Site = , Source = .NET Runtime, Message = Application: Vintagestory.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: exception code c0020001, exception address 00007FFF1DA13B29
Stack:
   at System.Environment._Exit(Int32)
   at System.Environment._Exit(Int32)
   at System.Environment.Exit(Int32)
   at _tbDNSZpN0b4WGkPbXXfou7PhsQl._4FaQHZNbeHKn9WINUsvqvFV8i9T()
   at Vintagestory.API.Client.GuiElementTextButton.OnMouseUpOnElement(Vintagestory.API.Client.ICoreClientAPI, Vintagestory.API.Client.MouseEvent)
   at Vintagestory.API.Client.GuiElement.OnMouseUp(Vintagestory.API.Client.ICoreClientAPI, Vintagestory.API.Client.MouseEvent)
   at Vintagestory.API.Client.GuiElementTextButton.OnMouseUp(Vintagestory.API.Client.ICoreClientAPI, Vintagestory.API.Client.MouseEvent)
   at Vintagestory.API.Client.GuiComposer.OnMouseUp(Vintagestory.API.Client.MouseEvent)
   at _VisI2OeWzgjAMuHLDUPaKaN5Lds._6J0Ioc1Jsh7Nj2siLiS88rTI5Ze(Vintagestory.API.Client.MouseEvent)
   at Vintagestory.Client.NoObf.ClientPlatformWindows.Mouse_ButtonUp(System.Object, OpenTK.Input.MouseButtonEventArgs)
   at System.EventHandler`1[[System.__Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].Invoke(System.Object, System.__Canon)
   at System.EventHandler`1[[System.__Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].Invoke(System.Object, System.__Canon)
   at OpenTK.Platform.Windows.WinGLNative.WindowProcedure(IntPtr, OpenTK.Platform.Windows.WindowMessage, IntPtr, IntPtr)
   at OpenTK.Platform.Windows.Functions.DispatchMessage(OpenTK.Platform.Windows.MSG ByRef)
   at OpenTK.Platform.Windows.Functions.DispatchMessage(OpenTK.Platform.Windows.MSG ByRef)
   at OpenTK.Platform.Windows.WinGLNative.ProcessEvents()
   at OpenTK.GameWindow.Run(Double, Double)
   at _lYLQLGyldvbDG9rPQyiRVeIqQVp._EEzpApWBQHtHR4iMJabXK2wDvlA(_ex0VSgRAdtsvhANmJHZHaf9ATWt, System.String[])
   at _IcGByoJhapvESnm6vaOawAHbkeU._EEzpApWBQHtHR4iMJabXK2wDvlA(System.Threading.ThreadStart)
   at _lYLQLGyldvbDG9rPQyiRVeIqQVp._k39DsboSFqAvcX2gaWs5Tk5Zl6Q(System.String[])
 }

 

[ZigTheHedge]

1.4.8-B:

- Fixed prices display on various GUI scale (thanks for the report, @Karielle Laganière)

- Fixed crash when trying to pick up Tradeomat with installed CarryCapacity (thanks for the report, @Aliysium)

- Fixed shift-click behavior

[ZigTheHedge]

1.4.9-B:

- Fixed crash in multiplayer when trying to purchase something from Trade'o'mats type 1 and 2.

- Fixed stacks merging in existing slots.

[Digitalr]

Uhm... Where is download link for 1.4.9?

There is only 1.4.7 and 1.4.8 versions for VS 1.14 in first message of this topic

[ZigTheHedge]

3 hours ago, Digitalr said:

Uhm... Where is download link for 1.4.9?

I got to stop doing things after midnight Now everything is in place, thanks for reporting!

[Volphox]

Hello!

I'm having some issues with the Trade'o'rug. When I right click or shift right click, nothing happens. I'm not sure if I'm doing something wrong. I absolutely love how it looks so I'm excited to use it! Thanks!

[ZigTheHedge]

Hi, @Volphox!

Does your game freezes a bit when you clicking of right-clicking trade’o’rug? Can you load a game, place trade’o’rug in world, make a single right-click and exit, afterwards upload your client-main.txt and server-main.txt here?

[MiniKarma]

The showcasing for accessories, like those, is off when put down. You can't even see the silver bracelet in this case.

For the stall variant, it is even worse, going from so tiny it is barely seeable, to not showing altogether.

I know it probably something hard to fix, but I just wanted it to me known ^^'''

[ZigTheHedge]

18 hours ago, MiniKarma said:

I know it probably something hard to fix, but I just wanted it to me known ^^'''

Unfortunately, you’re right. I can’t think of a possible way to render clothing-items in world correctly...